Repository navigation
fix(server): PowerPoint speaker notes leave out the notes page's slide number, date, header and footer - #40568
Conversation
…e number, date, header and footer
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…covers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EvidenceUploaded the same synthetic two-slide deck in the real web client on fresh databases. Opened an unchanged copy of each server-generated extracted-text sidecar in T3's file viewer. Chromium, 1280×800, light theme, replay provider. Proven: the scenario fails on base and passes on head. Base includes notes-page decorations and a false Notes label for the empty-notes slide. Head retains genuine notes and visible slide text and removes both defects.
Scenario · Synthetic deck · Deck generator Not shown:
|


Problem
When a .pptx is attached, the agent gets each slide's speaker notes under
Notes:. A PowerPoint notes page has placeholder shapes besides the notes: the slide image, slide number, date, header, and footer. The worker prints every paragraph on the page, so:Notes:followed by its slide number;Running the extractor over Apache POI's sample decks shows it, for example:
Change
Before printing a notes page, the worker leaves out
p:spshapes whosep:phtype issldImg,sldNum,dt,hdr, orftr. The body placeholder and any other shape on the notes page stay.Notes:is printed only when the remaining page has text (hasCellText), and the notes still stream through the existing output limits. Only the notes page is filtered. A slide's own number and footer are visible slide text, and they stay.Scope
This is a small fix for an obvious bug, so it has no issue. In 26 of the 28 Apache POI sample decks that have notes pages, those pages carry a cached slide number, so the agent reads it as a note, and a slide with empty notes gets a false
Notes:label. Open #38542 applies the same rule to OpenDocument notes ("A notes page with only an empty thumbnail adds no label") and doesn't touch the .pptx branch.Verification
The existing PPTX row in
userInputAttachments.test.tsnow uses a realistic notes page, with the slide image, body, header, date, footer, and slide number placeholders. Itsabsentlist gains the placeholder texts. A new row in the same table has a notes page with only the slide image, an empty body, and a slide number, and expects noNotes:. Another new row puts notes text before a table that hits the row limit, and checks that the text and the truncation marker both appear.With the fix, the two POI decks above extract as
"## Slide 1"and"...Notes:\n\naccount".vp run check:changed upstream/mainpasses.Claude Fable 5.2 (high, Claude Agent in T3 Code) found the bug. Claude Opus 5.5 (high) and GPT-6.2 Sol (high, Codex) reproduced it independently. Claude Opus 5.5 (Claude Agent in T3 Code) wrote the fix and test. Claude Opus 5.5 (xhigh), GPT-6.2 Sol, GPT-6.2 Astra (high, Codex), and Claude Fable 5.2 reviewed the final patch in T3 Code.